Skip to content

fix(developer): resolve input project path for kmc copy 🍒 🏠#15703

Merged
mcdurdin merged 1 commit into
stable-18.0from
fix/developer/cherry-pick/15659-resolve-input-path-for-kmc-copy
Mar 9, 2026
Merged

fix(developer): resolve input project path for kmc copy 🍒 🏠#15703
mcdurdin merged 1 commit into
stable-18.0from
fix/developer/cherry-pick/15659-resolve-input-path-for-kmc-copy

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Mar 9, 2026

Relative paths would cause kmc copy to fail to find sources files for the project, because component paths would be constructed incorrectly. The cleanest fix is to ensure that we always full resolve local file paths before attempting to copy the project.

Fixes: #15659
Cherry-pick-of: #15700
Test-bot: skip

@github-project-automation github-project-automation Bot moved this to Todo in Keyman Mar 9, 2026
@github-actions github-actions Bot added developer/ developer/compilers/ cherry-pick Change already merged into another (stable) branch fix stable labels Mar 9, 2026
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot Bot commented Mar 9, 2026

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot Bot changed the title fix(developer): resolve input project path for kmc copy 🍒 fix(developer): resolve input project path for kmc copy 🍒 🏠 Mar 9, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S24 milestone Mar 9, 2026
Relative paths would cause `kmc copy` to fail to find sources files for
the project, because component paths would be constructed incorrectly.
The cleanest fix is to ensure that we always full resolve local file
paths before attempting to copy the project.

Fixes: #15659
Cherry-pick-of: #15700
@mcdurdin mcdurdin force-pushed the fix/developer/cherry-pick/15659-resolve-input-path-for-kmc-copy branch from 0194522 to 67c7d84 Compare March 9, 2026 06:11
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit 7c1f3b6 into stable-18.0 Mar 9, 2026
8 checks passed
@mcdurdin mcdurdin deleted the fix/developer/cherry-pick/15659-resolve-input-path-for-kmc-copy branch March 9, 2026 09:02
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Mar 9, 2026
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick Change already merged into another (stable) branch developer/compilers/ developer/ fix stable

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants