refactor(web): move common code to abstract KeyboardProcessor base class 🎼#15893
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
KeyboardProcessor base classKeyboardProcessor base class 🎼
ermshiperete
force-pushed
the
refactor/web/kbdProcessor
branch
from
3249b1d to
6b766f8
Compare
…class This change moves code that was implemented in both `JSKeyboardProcessor` and `CoreKeyboardProcessor` to the `AbstractKeyboardProcessor`. This got renamed from `KeyboardProcessor` and is now a generic abstract class. Also removed some of the band-aids in `CoreKeyboardInterface` and `JSKeyboardInterface` that I put in before: Typescript allows implementations to have a slightly different method signature and still matches the interface as long as the used types are derived from the ones specified in the interface. Follows: #15870 Build-bot: skip build:web Test-bot: skip
ermshiperete
force-pushed
the
refactor/web/kbdProcessor
branch
from
6b766f8 to
10fcfe4
Compare
mcdurdin
approved these changes
Apr 30, 2026
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM. I am always a bit cautious about adding more layers of abstraction but this looks appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves code that was implemented in both
JSKeyboardProcessorandCoreKeyboardProcessorto theAbstractKeyboardProcessor. This got renamed fromKeyboardProcessorand is now a generic abstract class.Also removed some of the band-aids in
CoreKeyboardInterfaceandJSKeyboardInterfacethat I put in before: Typescript allows implementations to have a slightly different method signature and still matches the interface as long as the used types are derived from the ones specified in the interface.Follows: #15870
Build-bot: skip build:web
Test-bot: skip