fix(windows): Ensure default locale always appears in list of locales#15984
Merged
mcdurdin merged 2 commits intoMay 22, 2026
Merged
Conversation
* Add `TKeymanPaths.KeymanLocalePath` for consistent access to locales folder, and update references. * Remove the `SKDefaultLanguageCode` string and hard code the default language in CustomisationMessages.pas. * Hide the test locale 'qqq' on release builds. Fixes: #15164
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions Test Artifacts
|
github-actions
Bot
added
windows/
common/
oem/
oem/fv/
oem/fv/windows/
windows/config/
labels
darcywong00
reviewed
May 21, 2026
| <!-- String Type: FormatString --> | ||
| <!-- Introduced: 7.0.230.0 --> | ||
| <string name="SKDefaultLanguageCode" comment="The default language code for this product. This should be the language that the product is created in. For Keyman this must stay 'en', for all translations.">en</string> | ||
|
|
Contributor
There was a problem hiding this comment.
I think we generally keep old strings in for the previous Keyman versions. And maybe mark to deprecate in 20.0?
Member
Author
There was a problem hiding this comment.
Hmm, do changes here percolate back to old versions? They shouldn't!
Contributor
There was a problem hiding this comment.
I mean when strings get removed in the English source strings, crowdin will remove them across the rest of the languages.
Our end-of-sprint download from crowdin only goes to master (19.0) though.
Member
Author
There was a problem hiding this comment.
Given the download from crowdin goes only to master, I think we remove them in 19.0 -- no need to keep them hanging about and making extra work for translators.
darcywong00
reviewed
May 21, 2026
Comment on lines
+40
to
+43
| SKeymanVersion190 = '19.0'; | ||
| SKeymanVersion180 = '18.0'; | ||
| SKeymanVersion170 = '17.0'; | ||
| SKeymanVersion160 = '16.0'; |
Member
Author
There was a problem hiding this comment.
No, just adding for completeness -- they may be used at any time and as I was adding the ENVIRONMENT_ vars thought I'd just add these at the same time.
Member
Author
|
@Meng-Heng you should be able to retest with the latest build on this PR now, thanks! |
Contributor
Test Specs
Test Results
|
keymanapp-test-bot
Bot
removed
the
user-test-required
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.237-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TKeymanPaths.KeymanLocalePathfor consistent access to locales folder, and update references.SKDefaultLanguageCodestring and hard code the default language in CustomisationMessages.pas.This is a candidate for back-port to stable-18.0.
Fixes: #15164
User Testing
TEST_LOCALES: In Keyman Configuration, open the list of available locales and verify that all expected locales are present. Note that the '[!!Ěńġľĭŝħ!!]' language will appear for test builds; this is not an error.
TEST_SWITCH: Switch locale to Khmer, exit Keyman Configuration, and reopen. Verify that 'English' appears in the list of available locales and can be selected.