chore(web): web-core preflight - strip core references#16040
Merged
Conversation
In order to maintain roughly the current build artifact size, strip out the unfinished core integration from what we merge with preflight. Test-bot: skip Build-bot: release:android,ios,developer,web
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
Bot
added
web/
common/
common/web/
cherry-pick
mcdurdin
changed the title
mcdurdin
commented
Jun 1, 2026
| builder_describe "Keyman common web modules" \ | ||
| :keyman-version \ | ||
| :langtags \ | ||
| :sentry-manager \ |
Member
Author
There was a problem hiding this comment.
This is I think missing from epic/web-core. Discovered when rebuilding after switching branches
| "outDir": "../../build/engine/obj/", | ||
| "tsBuildInfoFile": "../../build/engine/obj/tsconfig.tsbuildinfo", | ||
| "rootDir": "./src", | ||
| "strictNullChecks": false |
Member
Author
There was a problem hiding this comment.
This is coming up across the codebase where we have made assumptions about null. We should have a review of this separately
ermshiperete
approved these changes
Jun 1, 2026
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.241-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to maintain roughly the current build artifact size, strip out the unfinished core integration from what we merge with preflight.
Test-bot: skip
Build-bot: release:android,ios,developer,web