Skip to content

Conversation

@dyacob
Copy link
Contributor

@dyacob dyacob commented Oct 20, 2025

This is an update to the GFF Tigrinya lexical model. The primary change to the language model is the addition of the "ti" tag, needed to support the GeezWord Tigrinya keyboard, which does not specify a language region.

Otherwise, the changes here are for the copyright year-end range to end at 2025. Also, KMD updated the project to the new project format. This seems to have touched the .tsv file, but I do not see the difference -maybe it is a change of newlines from Unix to DOS style?

@keyman-server
Copy link

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@dyacob
Copy link
Contributor Author

dyacob commented Oct 28, 2025

Hello, I would like to pause this PR. What I would like to do is the following across 3 Tigrinya lexical models:

  1. Deprecate this original, UniLex-based, lexical model. Perhaps give it a dummy language or region code so Keyman never retrieves it.
  2. Add the region-neutral tag ti to both the gff.ti_et.gff_tgrinya_ethiopia and gff.ti_er.gff_tgrinya_eritrea lexical models.

The motivation here is to make these later two keyboards discoverable to Tigrinya keyboards that do not specify a region. But also make the older, inferior keyboard, unavailable. My assumption is that a user installing a keyboard with the ti tag will be offered a choice of the two keyboards for either Ertirea or Ethiopia and will select as per their needs.

I will proceed to make the necessary revisions. LMK if there are other issues to consider. Thanks!

@DavidLRowe
Copy link
Collaborator

The original .tsv file has Unix (LF) line endings. The new .tsv file has Windows (CR LF) line endings and also begins with a BOM.

You may want to use the "Convert to Draft" option (under "Reviewers" in upper right) to reflect your desire to wait.

@dyacob
Copy link
Contributor Author

dyacob commented Oct 29, 2025

Unpause. With #332 & #333 now submitted, this group of 3 PRs for Tigrinya dictionaries can be processed together.

@dyacob
Copy link
Contributor Author

dyacob commented Oct 29, 2025

Coming into #218 (comment) , I would like to change this PR to a deletion request.

I could make a new commit that deletes the contents and folder. Is this an appropriate deletion process? Would any other steps be needed?

@DavidLRowe
Copy link
Collaborator

@mcdurdin Can you confirm that what you wrote two years ago about deleting this outdated lexical model is still your recommendation? Assuming it is, @dyacob can update this PR to delete the lexical model entirely.

Meanwhile I'll look at the two new lexical models and make sure they are merged before processing this PR (once it is revised to delete the lexical model).

@dyacob
Copy link
Contributor Author

dyacob commented Oct 29, 2025

@DavidLRowe yes, I can delete the contents. I think with keyboards the policy is to never delete them, only mark them as deprecated. Since the lexical models download automatically, I think deleting is better to avoid any user-side confusion.

However, if the Keyman group would like to keep them around, I think it is good to have policy that avoids them ever being retrieved unintentionally. Which could be accomplished by applying a dummy language tag that would never be queried.

@LornaSIL
Copy link
Collaborator

The keyboards have a url so we keep them for that stability. For lexical-models I don't think we have the same concern and we always have the github history if the model is deleted.

@dyacob
Copy link
Contributor Author

dyacob commented Oct 29, 2025

The last update to this branch makes the deletion of the dictionary folder and its contents.

@DavidLRowe DavidLRowe merged commit 349354f into keymanapp:master Oct 29, 2025
2 checks passed
@mcdurdin
Copy link
Member

mcdurdin commented Nov 3, 2025

Can you confirm that what you wrote two years ago about deleting this outdated lexical model is still your recommendation?

Yes, I think so. As lexical models are installed automatically alongside corresponding keyboards, and as they don't tend to have a real "identity" of their own, there is not as much of a reason to keep them about if they are made obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants