Skip to content

maint: upgrade probot to 14.x#637

Draft
mcdurdin wants to merge 2 commits into
masterfrom
maint/upgrade-probot
Draft

maint: upgrade probot to 14.x#637
mcdurdin wants to merge 2 commits into
masterfrom
maint/upgrade-probot

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

This needs to be verified before deployment. Builds on dependabot PR.

Test-bot: skip

dependabot Bot and others added 2 commits April 23, 2026 02:20
Removes [uuid](https://github.com/uuidjs/uuid). It's no longer used after updating ancestor dependency [probot](https://github.com/probot/probot). These dependencies need to be updated together.


Removes `uuid`

Updates `probot` from 12.4.0 to 14.3.2
- [Release notes](https://github.com/probot/probot/releases)
- [Commits](probot/probot@v12.4.0...v14.3.2)

---
updated-dependencies:
- dependency-name: uuid
  dependency-version: 
  dependency-type: indirect
- dependency-name: probot
  dependency-version: 14.3.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
This needs to be verified before deployment.
@keymanapp-test-bot
Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S28 milestone Apr 29, 2026
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +51 to +57
// const probot = createProbot({
// env: {
// APP_ID: appId.toString(),
// PRIVATE_KEY: privateKey,
// WEBHOOK_SECRET: secret,
// }
// });
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets uncommented for deployment?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly this whole PR should probably be brought back to draft because I am very much lacking in confidence that the update to probot 14.x is actually correct. I need to test it locally, which is kinda a hassle to setup (still want to split testbot out of status site at some point, too)

@mcdurdin mcdurdin marked this pull request as draft April 30, 2026 12:22
@keyman-server keyman-server modified the milestones: A19S28, A19S29 May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants