fix: Add tests for analyzing if statements without else clauses#4
Merged
Conversation
Introduce new test cases in analyzer_test.go to evaluate the behavior of the Analyze function when handling if statements that lack else clauses. The tests cover scenarios with terminating bodies, non-terminating bodies, and panic conditions. Additionally, update branch candidate collection logic in branches.go to correctly identify implicit false paths based on the structure of the if body. Enhancements include the addition of helper functions for checking if a body terminates and for determining if fallthrough conditions are met, improving the accuracy of branch coverage analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce new test cases in analyzer_test.go to evaluate the behavior of the Analyze function when handling if statements that lack else clauses.
The tests cover scenarios with terminating bodies, non-terminating bodies, and panic conditions. Additionally, update branch candidate collection logic in branches.go to correctly identify implicit false paths based on the structure of the if body.
Enhancements include the addition of helper functions for checking if a body terminates and for determining if fallthrough conditions are met, improving the accuracy of branch coverage analysis.