Skip to content

cunder-12: add gh actions unittest & format#12

Open
ghost wants to merge 12 commits into
mainfrom
gh-actions-ci
Open

cunder-12: add gh actions unittest & format#12
ghost wants to merge 12 commits into
mainfrom
gh-actions-ci

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 6, 2023

This PR adds github actions for building and running Unittests, and another for formatting C/C++ source/header files.

@ghost ghost requested a review from khaledkee March 6, 2023 18:06
@ghost ghost self-assigned this Mar 6, 2023
@khaledkee
Copy link
Copy Markdown
Owner

The windows and linux library is failing because of the hard-coded path, right?

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 8, 2023

Yes, specifically it fails because cmake doesn't find LibTorch, hence won't build cunder or unittests.

@ghost ghost added the in progress PR is in progress (temporary tag) label Mar 9, 2023
Youssef Kamal added 6 commits March 13, 2023 10:40
add required headers for linux build
change `\\` to `/` for valid paths
unset `unittests/data` as git-lfs from `.gitattributes`
move `corecrt_malloc.h` to header file in a guard include
revert adding python scripts to unittest data
remove `REQUIRED` from the first two `find()` calls
add libtorch windows abi
try removing `corecrt.h` since gcc doesn't recognise it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in progress PR is in progress (temporary tag)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant