Skip to content

Sprint4/feature/us 3.2 location class#251

Merged
khalillabban merged 18 commits intomainfrom
sprint4/feature/us-3.2-location-class
Mar 8, 2026
Merged

Sprint4/feature/us 3.2 location class#251
khalillabban merged 18 commits intomainfrom
sprint4/feature/us-3.2-location-class

Conversation

@philniko
Copy link
Copy Markdown
Collaborator

@philniko philniko commented Mar 7, 2026

  • Persist course schedule for future "directions to next class" feature

  • Stores parsed Google Calendar course data (campus, building, room) to AsyncStorage so it can be retrieved across sessions. Adds getNextClass() to look up the user's next upcoming class — groundwork for automatically routing the user to their next course location.

  • Also fixes broken test suites (parseCourseEvents, Schedule) by adding a global AsyncStorage mock, and adds missing test coverage for saveSchedule, loadCachedSchedule, getNextClass, pagination in the Calendar API, and token validation edge cases.

Closes #13
Closes #229

@philniko philniko added this to the Sprint 4 milestone Mar 7, 2026
@philniko philniko added the enhancement New feature or request label Mar 7, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in Snorting Code Mar 7, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 7, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 97.10145% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/schedule.tsx 91.66% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@tinaw1412 tinaw1412 self-requested a review March 7, 2026 02:18
Comment thread app/schedule.tsx Outdated
Copy link
Copy Markdown
Owner

@khalillabban khalillabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good guys, just some suggestions for tightening code.

Comment thread __tests__/GoogleCalendarService.test.tsx Outdated
Comment thread __tests__/GoogleCalendarService.test.tsx
Comment thread __tests__/GoogleCalendarService.test.tsx Outdated
Comment thread __tests__/GoogleCalendarService.test.tsx Outdated
Comment thread __tests__/parseCourseEvents.test.tsx
Comment thread utils/parseCourseEvents.ts Outdated
Comment thread utils/parseCourseEvents.ts Outdated
Comment thread utils/parseCourseEvents.ts Outdated
Comment thread utils/parseCourseEvents.ts Outdated
Comment thread utils/parseCourseEvents.ts Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 8, 2026

@zachcorber zachcorber removed their request for review March 8, 2026 05:55
Copy link
Copy Markdown
Owner

@khalillabban khalillabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@khalillabban khalillabban merged commit 7862bdd into main Mar 8, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Snorting Code Mar 8, 2026
@khalillabban khalillabban deleted the sprint4/feature/us-3.2-location-class branch March 8, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

AT-3.2: Classroom location from schedule data US-3.2: Classroom location from schedule data

6 participants