Skip to content

Added accessibility routing functionality#300

Merged
NicG27 merged 15 commits intomainfrom
sprint5/feature/us-4.3-accessibility-routes
Mar 24, 2026
Merged

Added accessibility routing functionality#300
NicG27 merged 15 commits intomainfrom
sprint5/feature/us-4.3-accessibility-routes

Conversation

@khalillabban
Copy link
Copy Markdown
Owner

@khalillabban khalillabban commented Mar 23, 2026

  • Introduced an accessible route toggle in the navigation UI and wired it into onConfirm so routes can require accessible paths
  • Added an accessible toggle button in Indoor Map Screen UI to allow users to switch between with and without accessibility routes
  • Updated indoor routing to respect accessibility on both nodes and edges, with a clear fallback/error when no accessible path exists
  • Improved route visualization and UX messaging to clearly distinguish accessible routing outcomes
  • Validated using real building plan data to ensure accessible attributes are correctly used
  • Expanded tests to cover accessible routing behavior, including toggle propagation and route selection
  • Fixed failing tests caused by updated behavior and labels (building picker accessibility labels and confirm arguments)
  • Resolved test structure issues (nested blocks, syntax, braces) and aligned coverage tests with the updated onConfirm signature including accessibleOnly
image Screenshot 2026-03-23 at 5 45 56 PM

Closes #17
Closes #270
Closes #301
Closes #302

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 96.52174% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
utils/indoorPathFinding.ts 93.10% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Comment thread app/IndoorMapScreen.tsx
Comment thread app/CampusMapScreen.tsx Outdated
Comment thread __tests__/NavigationBar.test.tsx
Comment thread __tests__/CampusMapScreen.test.tsx
Comment thread components/IndoorRouteOverlay.tsx Outdated
Comment thread app/CampusMapScreen.tsx Outdated
Comment thread components/IndoorRouteOverlay.tsx
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@NicG27 NicG27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes!

@NicG27 NicG27 merged commit 0a436eb into main Mar 24, 2026
3 checks passed
@0x-Nyx 0x-Nyx deleted the sprint5/feature/us-4.3-accessibility-routes branch March 28, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

7 participants