Sprint5/feature/us 4.5 indoor points of interest for services

[NicG27]

Added a toggleable points of interest (POI) overlay to the indoor map, fixed indoor navigation connectivity for VL and MB buildings, and improved the MB floor map rendering.

• Added a full-width icon toggle bar below the floor selector with one button per POI category (washrooms, water fountains, stairs, elevators, entrances)
• Tapping a toggle shows/hides that category's POI markers on the current floor
• POI markers are scaled and positioned using the same coordinate/stage system as room markers
• Added missing entrance and stair nodes with connecting edges to the navigation graphs for MB, VL, and CC

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[khalillabban]

Incredible work, Nick. Just a few changes that you can definitely debate if you think they're unnecessary.

[khalillabban]

Can we confirm whether getIndoorPOIs(buildingName) is expensive enough to justify useMemo here? If this is just a static lookup, a plain const may be simpler and easier to read. Not blocking, just checking whether memoization is actually buying us anything. This is a possibility:

const allPOIs = buildingName ? getIndoorPOIs(buildingName) : [];

[NicoLandry]

Agreed, getIndoorPOIs is just a static lookup so there's no need for memoization. Replaced it with a plain const.

[NicoLandry]

@khalillabban all review comments have been addressed in the latest commits:

1. Fixed useEffect deps for floor reset and initial room query
2. Replaced allPOIs useMemo with a plain const
3. Removed the unreachable if (!trimmedQuery) branch
4. Added accessibilityHint to POI filter chips
5. Typed POI_CATEGORIES and POI_CATEGORY_MAP with MaterialIconName to remove icon casts
6. Added accessible={false} + importantForAccessibility to the overlay
7. Normalized activeCategories with activeCategoryIds to avoid extra re-renders
8. SonarQube quality gate is passing.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[khalillabban]

Incredible work gentlemen!