Conversation
Created POI categories, range selector UI, get user's location (mostly the same as normal location), theoretically getting POIs - will need to enable Places API where directions and maps are being allowed, filtering POIs by range inside Google Places API and displaying them.
POIs are now displayed in a list view, results change based on range/category and theoretically range (cannot be tested on simulator due to limitations) Search Nearby button removed and replaced with live results, category names changed to fit neatly and edge cases theoretically handled Known limitation - due to the nature of the Search Nearby operation, only the 20 most popular entries are returned. This is an API limit, not something that can be raised.
Add new tests for Google Places service, nearby POI hook, POI filter/range/list components, CampusMap POI focus flow, and CampusMapScreen POI interactions. Also suppress expected console noise in indoor and map suites so full npm test output stays clean.
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Remove unused canSearchPOIs assignment and keep deterministic POI category key sorting with an explicit comparator for sonar compliance.
…into sprint6/feature/us-5.1-show-nearest-outdoor-points-of-interest
Resolve CI/Jest parse failure on PR merge ref by keeping a single parseTransitionPayload/serializeTransitionPayload import in CampusMapScreen.
NicoLandry
left a comment
NicoLandry
left a comment
There was a problem hiding this comment.
Overall the outdoor POI feature is solid the service layer, hook, and UI components are all well structured and the live search on category/range change is a nice touch. A few things worth addressing: silent API failures in fetchNearbyPOIsForCategories should surface something to the user, the haversineMeters function should live in a shared util, and the eslint-disable on the search effect needs a comment explaining why it's safe. Also the .DS_Store file shouldn't be in the commit. Nothing blocking but worth cleaning up before merge.
|
Please add a toggle for the nearby places overlay, it shouldn't always be visible. |
Doing this too - .DS_Store should already be in the git ignore
Adding dependency to fix CI issue
|
khalillabban
deleted the
sprint6/feature/us-5.1-show-nearest-outdoor-points-of-interest
branch
5 participants
Closes #23
Closes #290