Skip to content

US-5.2: Show directions for selected outdoor point of interest#325

Merged
khalillabban merged 2 commits intomainfrom
sprint6/feature/us-5.2-outdoor-poi-directions
Mar 30, 2026
Merged

US-5.2: Show directions for selected outdoor point of interest#325
khalillabban merged 2 commits intomainfrom
sprint6/feature/us-5.2-outdoor-poi-directions

Conversation

@khalillabban
Copy link
Copy Markdown
Owner

@khalillabban khalillabban commented Mar 30, 2026 •
edited
Loading

  • Implemented outdoor POI directions from both list and map pin selection.
  • Implemented a selected POI panel with Get directions and Clear actions.
  • Implemented POI destination routing with current-location start + fallback.
  • Implemented POI route recalculation when the selected destination changes.
  • Implemented user-facing error handling for POI routing failures.
  • Implemented tests for the new POI routing flow and edge cases.
image

Closes #24
Closes #291

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2026 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/CampusMapScreen.tsx 97.91% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

NicG27
NicG27 reviewed Mar 30, 2026
View reviewed changes
Comment thread app/CampusMapScreen.tsx Outdated
Comment thread app/CampusMapScreen.tsx Outdated
Comment thread app/CampusMapScreen.tsx Outdated
Comment thread app/CampusMapScreen.tsx Outdated
NicG27
NicG27 approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@NicG27 NicG27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good job!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khalillabban khalillabban merged commit 6ac7cb6 into main Mar 30, 2026
3 checks passed
@khalillabban khalillabban deleted the sprint6/feature/us-5.2-outdoor-poi-directions branch March 30, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicG27 NicG27 NicG27 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AT-5.2: Show directions for selected outdoor point of interest US-5.2: Show directions for selected outdoor point of interest

3 participants

@khalillabban @codecov-commenter @NicG27