REF-18: extract shared requireGoogleApiKey into googleEnvUtils#376
Merged
khalillabban merged 1 commit intomainfrom Apr 5, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
khalillabban
approved these changes
Apr 5, 2026
khalillabban
deleted the
sprint6/refactor/extract_shared_requireGoogleApiKey
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoogleDirectionsService and GooglePlacesService each had their own copy of requireGoogleApiKey() with slightly different error messages. This extracts the function into a new services/googleEnvUtils.ts module and replaces both local copies with an import.
No behavior change, any new Google service that needs the Maps API key now has a single place to import from.
closes #375