fix: prevent terminal viewport jumping to line 0 on tab/window switch#7
Merged
fix: prevent terminal viewport jumping to line 0 on tab/window switch#7
Conversation
Track scroll intent with an explicit `pinnedToBottom` boolean instead of checking the instantaneous viewportY >= baseY buffer state. xterm.js doesn't keep the viewport pinned when the terminal is display:none (tab switches) or offscreen (OS window switches), causing fitAddon.fit() to miscompute scroll position and reset to line 0. Also adds a floating "scroll to bottom" button that appears when the user has scrolled up, with wheel event fallback for trackpad detection since xterm's onScroll doesn't fire for user-initiated viewport moves. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Combine scroll tracking (pinnedToBottom, wheelHandler, scrollCleanup) with debounced PTY resize (debouncedPtyResize, cleanupResizeTimer) so both features coexist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 19, 2026
khang859
added a commit
that referenced
this pull request
Mar 29, 2026
Running/idle state indicator now implemented in copilot SessionList via multi-signal Badge component. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pinnedToBottomstate instead of relying on xterm's buffer position (which is unreliable when the terminal isdisplay:noneor offscreen)onScrolldoesn't fire for trackpad/mouse wheel viewport movesfitAddon.fit(), explicitly callscrollToBottom()when pinned, instead of trusting xterm to stay at bottomTest plan
🤖 Generated with Claude Code