Skip to content

Conversation

@tkkuehn
Copy link
Collaborator

@tkkuehn tkkuehn commented Jan 25, 2023

Proposed changes

This indexes the output metadata based on the input metadata files, not the values in the images as it did before. Side benefit: We get a nicer error messages if there are undocumented values in the input label maps.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@tkkuehn tkkuehn added the enhancement New feature or request label Jan 25, 2023
Copy link
Collaborator

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

I wonder if it would also be beneficial to include a warning if labels are missing from the label image that exist in the metadata. Can discuss at next meeting.

@tkkuehn
Copy link
Collaborator Author

tkkuehn commented Jan 26, 2023

I wonder if it would also be beneficial to include a warning if labels are missing from the label image that exist in the metadata.

I considered this but opted against it for now. Added to the agenda for next meeting.

@tkkuehn tkkuehn merged commit 3d57c27 into main Jan 26, 2023
@tkkuehn tkkuehn deleted the new-indexing branch January 26, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants