Skip to content

Conversation

@kaitj
Copy link
Collaborator

@kaitj kaitj commented Feb 9, 2023

Proposed changes

This updates the pipeline_description.json file to reflect Labelmerge. Also adds in a step in the release workflow to bump the version shown in this file whenever a new release is made.

Resolves #39

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Feb 9, 2023
@kaitj kaitj requested a review from tkkuehn February 9, 2023 20:28
@kaitj kaitj self-assigned this Feb 9, 2023
@kaitj kaitj force-pushed the docker-fix branch 4 times, most recently from 8891e4b to 087fd7f Compare February 9, 2023 21:50
Copy link
Collaborator

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe needs a merge from docker-fix to get rid of the duplicated changes in the diff, but the changes to release.yml and pipeline_description.json look good to me.

- includes the labelmerge package for installation
Base automatically changed from docker-fix to main February 13, 2023 14:41
@tkkuehn tkkuehn merged commit 47d337e into main Feb 13, 2023
@tkkuehn tkkuehn deleted the pipeline_desc branch February 13, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Updates or improvements that do not change functionality of the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pipeline_description.json version

3 participants