Skip to content

Conversation

@kaitj
Copy link
Collaborator

@kaitj kaitj commented Mar 6, 2023

Proposed changes

This PR adds in searchable documentation via readthedocs. From the readthedocs side, I've hidden the latest version, which points to main and instead defaulted the docs to stable, which should always point to the most recently released tagged version. In addition, I've enabled version tagging and activation so that there will be documentation specific to each released version - these tagged versions can be manually removed from the doc sidebar if needed. Lastly, PR builds have been enabled, so there will be a preview of the documentation for each PR.

Also using this PR to fix spelling in the PR template (functionalitiy -> functionality)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the documentation Improvements or additions to documentation label Mar 6, 2023
@kaitj kaitj force-pushed the docs branch 5 times, most recently from 26bc3b6 to 9061b05 Compare March 6, 2023 20:38
@kaitj kaitj marked this pull request as ready for review March 9, 2023 22:32
@kaitj
Copy link
Collaborator Author

kaitj commented Mar 9, 2023

Should be good for a review now. Some of the images may not render until merged since I put the expected path in. I found that relative paths didn't work in the preview.

@kaitj kaitj mentioned this pull request Apr 19, 2023
9 tasks
Copy link
Contributor

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This largely looks good, I've mostly noted some typos and stylistic things

@kaitj kaitj force-pushed the docs branch 3 times, most recently from ae571fe to 2e16a0d Compare April 21, 2023 09:56
@kaitj kaitj requested a review from tkkuehn April 24, 2023 17:22
Jason Kai added 20 commits April 24, 2023 16:31
- relative links did not load in readthedocs
- should show up once merged
- remove enlarge feature for dag image
- add labelmerge cli options, allowing for easier swapping of atlases
and labelmaps
- update documentation FAQ with information about using other atlases
- run quality fixes through files
- add warning for use of custom atlases
- skip use of cortical ribbon as its not needed with convex hull
- add `--skip_labelmerge` argument to allow use of single atlas for
targetted structures
- add test cases in actions workflow
- update faq to reflect changes with `--skip_labelmerge`
- fix pre-prended -> pended
- add link to relevant section in bids specification
@kaitj kaitj merged commit 817021a into main Apr 24, 2023
@kaitj kaitj deleted the docs branch April 24, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants