Added innerException parameter to constuctor of ProblemDetailsException #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khellang
reviewed
Sep 14, 2021
Owner
|
Amazing. Thank you very much! ✨ |
Owner
|
Pushed v6.2.0 to NuGet 😄 Thanks again! |
Contributor
Author
|
Great, thx to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creating the ProblemDetailsException it's still not clear if its ProblemDetails should contain exceptionDetails property or not as this is dependent on options which are unavailable when creating the ProblemDetailsException.
Adding the exceptionDetails to ProblemDetails of ProblemDetailsException is therefore handled in ProblemDetailsFactory.