Skip to content

Feature: Added shouldSpellCheck to SingleLineInput and MultiLineInput #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krishan711 merged 2 commits into from
Dec 5, 2024
+6 −1
Merged

Feature: Added shouldSpellCheck to SingleLineInput and MultiLineInput #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f38a362
.
krishan711 Dec 5, 2024
adebe23
.
krishan711 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [MINOR] Added `onFrameClicked` to `SingleLineInput`
- [MINOR] Added `iconRight` and `iconLeft` to `InputFrame`
- [MINOR] Added `isScrollableVertically` and `isScrollableHorizontally` and `shouldMatchAnchorWidth` and `shouldMatchAnchorHeight` to `Portal`
- [MAJOR] Changed GlobalCSS to not stop body scrolling on webkit
- [MAJOR] Changed `GlobalCSS` to not stop body scrolling on webkit
- [MINOR] Added `shouldSpellCheck` to `SingleLineInput` and `MultiLineInput`

### Removed

Expand Down
2 changes: 2 additions & 0 deletions src/molecules/multiLineInput/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ interface IMultiLineInputProps extends IMoleculeProps<IMultiLineInputTheme> {
label?: string;
inputWrapperVariant?: string;
shouldAutofocus?: boolean;
shouldSpellCheck?: boolean;
onKeyUp?: (key: string) => void;
onKeyDown?: (key: string) => void;
onClick?: () => void;
Expand Down Expand Up @@ -128,6 +129,7 @@ export function MultiLineInput({
aria-label={props.label || props.name || props.placeholderText}
placeholder={props.placeholderText}
autoFocus={props.shouldAutofocus}
spellCheck={props.shouldSpellCheck}
/>
</InputFrame>
);
Expand Down
2 changes: 2 additions & 0 deletions src/molecules/singleLineInput/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export interface ISingleLineInputProps extends IMoleculeProps<ISingleLineInputTh
iconGutter?: PaddingSize;
childAlignment?: Alignment;
contentAlignment?: Alignment;
shouldSpellCheck?: boolean;
onKeyUp?: (key: string) => void;
onKeyDown?: (key: string) => void;
onClicked?: () => void;
Expand Down Expand Up @@ -148,6 +149,7 @@ export const SingleLineInput = React.forwardRef(({
placeholder={props.placeholderText}
autoFocus={props.shouldAutofocus}
onWheelCapture={onWheelCapture}
spellCheck={props.shouldSpellCheck}
ref={ref}
/>
</InputFrame>
Expand Down