Fix: lots of small fixes + use focus-visible instead of FocusFixer pattern#231
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements several small fixes across the UI-React library, primarily focused on adding proper style prop forwarding to molecule components and improving color variant generation in SCSS.
- Adds
styleprop toIMoleculePropsinterface and forwards it to all molecule components - Fixes color-mix syntax in SCSS to correctly calculate light/dark variants
- Removes deprecated
IComponentPropsCompatinterface and unused import
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/colors.scss | Corrects color-mix percentages for light/dark variants, adds new light01/dark01 variants and brand-dark color |
| src/particles/media/component.tsx | Adds explicit style prop forwarding to Video, WebView, and Image components |
| src/molecules/tabBar/component.tsx | Merges style prop into contentAlignmentStyle object |
| src/molecules/singleLineInput/component.tsx | Forwards style prop to InputFrame |
| src/molecules/progressCounter/component.tsx | Forwards style prop to root div |
| src/molecules/optionSelect/component.tsx | Forwards style prop to root div |
| src/molecules/multiLineInput/component.tsx | Forwards style prop to InputFrame |
| src/molecules/moleculeProps.ts | Adds style prop to IMoleculeProps interface |
| src/molecules/messageDialog/component.tsx | Forwards style prop to Dialog component |
| src/molecules/markdownText/component.tsx | Adds style prop to interface and forwards to PrettyText |
| src/molecules/list/component.tsx | Forwards style prop to root div |
| src/molecules/inputFrame/component.tsx | Forwards style prop to InputWrapper |
| src/molecules/form/component.tsx | Forwards style prop to Box component |
| src/molecules/carousel/component.tsx | Forwards style prop to Stack component |
| src/molecules/appDownloadButton/component.tsx | Forwards style prop to LinkBase |
| src/model/componentProps.tsx | Removes deprecated IComponentPropsCompat interface and RecursivePartial import |
| src/layouts/stack/component.tsx | Improves StackItem detection, fixes style merge order, and forwards style prop |
| src/atoms/iconButton/component.tsx | Forwards style prop to ButtonComponent |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* 'fixes' of github.com:kibalabs/ui-react: Apply suggestion from @Copilot Apply suggestion from @Copilot
krishan711
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* 'fixes' of github.com:kibalabs/ui-react: Update src/layouts/stack/component.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots:
Checklist: