Skip to content

Fiddle: update deployment structure#235

Merged
krishan711 merged 2 commits into
mainfrom
deploy
Dec 10, 2025
Merged

Fiddle: update deployment structure#235
krishan711 merged 2 commits into
mainfrom
deploy

Conversation

@krishan711
Copy link
Copy Markdown
Contributor

Description

Screenshots:

Checklist:

  • I have updated the CHANGELOG with a summary of my changes
  • I have updated the documentation accordingly

Copilot AI review requested due to automatic review settings December 10, 2025 14:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the GitHub Actions deployment workflows by separating package deployment concerns from documentation deployment, improving organization and clarity of the deployment pipeline.

  • Splits deployment responsibilities: package/release creation moved to deploy.yml, documentation deployment isolated to deploy-docs.yml
  • Adds tag-based triggers to enable versioned releases alongside continuous deployment
  • Consolidates the create-release job into the main deployment workflow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/deploy.yml Renamed from package-next deployment to unified package deployment; added tag trigger support, conditional npm publishing for tags vs main branch, and GitHub release creation
.github/workflows/deploy-docs.yml Renamed from Release workflow; added main branch trigger and workflow_dispatch; moved docs deployment jobs from deploy.yml; removed create-release job (moved to deploy.yml)
Comments suppressed due to low confidence (4)

.github/workflows/deploy-docs.yml:27

  • The docker/setup-buildx-action@v1 and docker/build-push-action@v2 actions are outdated. Consider upgrading to docker/setup-buildx-action@v3 and docker/build-push-action@v5 respectively for better performance and security.
    .github/workflows/deploy-docs.yml:11
  • The deploy-docs-next job runs on every push to main and every tag push, which may not be intended. The next docs should typically only deploy on pushes to main (development builds), not on tag releases. Consider adding a condition:
deploy-docs-next:
  if: github.ref == 'refs/heads/main'

This prevents deploying the -next docs when creating versioned releases.
.github/workflows/deploy-docs.yml:17

  • The actions/checkout@v2 action is outdated. Consider upgrading to actions/checkout@v4 which is the current stable version with improved performance and security fixes.
    .github/workflows/deploy-docs.yml:19
  • The docker/login-action@v2 action is outdated. Consider upgrading to docker/login-action@v3 which includes security improvements and bug fixes.

Comment thread .github/workflows/deploy.yml
Comment thread .github/workflows/deploy.yml Outdated
Comment thread .github/workflows/deploy.yml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

.github/workflows/deploy-docs.yml:11

  • The deploy-docs-next job runs on every push to main and for all tags, but it should likely only run for pushes to the main branch. Consider adding a condition if: github.ref == 'refs/heads/main' to this job to prevent it from running on tag pushes, similar to how deploy-docs only runs on tags.
    .github/workflows/deploy-docs.yml:35
  • The run-docs-next job will also run on tag pushes since its dependency deploy-docs-next runs on tags. Consider adding if: github.ref == 'refs/heads/main' to this job to prevent it from running unnecessarily on tag pushes.

@krishan711 krishan711 merged commit 3f99d41 into main Dec 10, 2025
10 checks passed
@krishan711 krishan711 deleted the deploy branch December 10, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants