Fiddle: add maxWidth to ContainingView#241
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a maxWidth prop to the ContainingView wrapper component, allowing developers to override the default maximum width (--kiba-screen-width-max) with a custom value.
Changes:
- Added
maxWidthprop toIContainingViewPropsinterface - Updated component logic to use custom
maxWidthwhen provided, falling back to CSS variable - Updated CHANGELOG with MINOR version entry
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/wrappers/containingView/component.tsx | Added optional maxWidth prop to interface and implementation to allow custom maximum width override |
| CHANGELOG.md | Documented the new maxWidth prop as a MINOR change |
|
|
||
| export interface IContainingViewProps extends IWrapperProps { | ||
| isCenteredHorizontally?: boolean; | ||
| maxWidth?: string; |
There was a problem hiding this comment.
The new maxWidth prop needs a Storybook story example demonstrating its usage. According to CONTRIBUTING.md: "Every component must be documented, and every variant must have a story example."
Consider adding a story that shows how to use a custom maxWidth value, for example:
export const CustomMaxWidth: Story = {
render: (args) => (
<ContainingView {...args}>
<Box variant='card'>
<Text>Content constrained to custom width</Text>
</Box>
</ContainingView>
),
args: {
maxWidth: '500px',
},
};This will help users discover and understand how to use the maxWidth prop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots:
Checklist: