Fix: correction for using childSizeResponsive.base in EqualGrid#244
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Grid component where sizeResponsive.base was not being used as a fallback value when the size prop was not provided. This particularly affects EqualGrid, which can pass childSizeResponsive to Grid items without a childSize prop.
Changes:
- Updated Grid component to use
childProps.sizeResponsive?.baseas a fallback before defaulting to 12 - Added CHANGELOG entry documenting the correction
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/layouts/grid/component.tsx | Added childProps.sizeResponsive?.base to the fallback chain when determining grid item size |
| CHANGELOG.md | Documented the correction in the Unreleased section |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots:
Checklist: