Skip to content

[MBL-2994] Show Featured badge#2475

Merged
jlpl15 merged 2 commits intomasterfrom
JL/MBL-2994
Feb 19, 2026
Merged

[MBL-2994] Show Featured badge#2475
jlpl15 merged 2 commits intomasterfrom
JL/MBL-2994

Conversation

@jlpl15
Copy link
Copy Markdown
Contributor

@jlpl15 jlpl15 commented Feb 19, 2026

📲 What

Wire Featured reward badge on reward cards (carousel and add-ons) in the same placement as Secret. Add Featured reward previews on KSRewardCard. Fix right-edge purple line on reward cards.

🤔 Why

Featured rewards need to be visually shown, like Secret rewards. The badge must appear wherever rewards are shown (carousel, manage pledge add-ons) so users can recognize featured rewards. The purple line on the right of cards was a layout/theme side effect and needed to be removed.

🛠 How

  • KSRewardCard: Added isFeatured and render KSFeaturedRewardBadge in the same three cases as Secret (above card when no image, over image bottom-start, and with “Your selection” when no image). Set Card colors and border = null, and clip(cardShape) on content to remove the right-side purple line.
  • RewardCarouselScreen: Pass isFeatured = reward.isFeatured() == true into KSRewardCard for reward items.
  • AddOnViewHolder: Show Featured badge using the same placement logic as Secret (over image or above card). Use a Row for Secret + Featured when both apply, with Modifier.wrapContentSize() so the badge doesn’t stretch.
  • Previews: Added four Featured-only previews mirroring Secret (ImageSelectedFeatured, ImageNoSelectedFeatured, NoImageSelectedFeatured, NoImageNoSelectedFeatured).

👀 See

Screen_recording_20260219_145145.webm

📋 QA

Test project: https://staging.kickstarter.com/projects/1613788818/tween-cats-chocolate
Secret reward link in case you want to test it full: https://staging.kickstarter.com/projects/1613788818/tween-cats-chocolate?secret_reward_token=15a36813

  1. Carousel: Open a project with a featured reward. Confirm the “Featured” badge (purple, star + text) appears on that reward’s card in the same spots as Secret (above card if no image, over image if present, or with “Your selection” when selected and no image). Confirm no purple vertical line on the right of any card.
  2. Manage pledge / Add-ons: Go to manage pledge and open add-ons. For a featured add-on, confirm the Featured badge appears (over image or above card, same as Secret). For a reward that is both Secret and Featured, confirm both badges show side by side.
  3. Secret unchanged: Confirm Secret badge behavior is unchanged and still appears only when reward.isSecretReward() == true.
  4. Previews: In Android Studio, open KSRewardCard.kt and run the four new “Featured” previews; confirm they match the Secret preview layouts with the Featured badge.

Story 📖

MBL-2994(Trello link)

…nt as Secret). Add Featured reward previews on KSRewardsCard.
Copy link
Copy Markdown
Contributor

@tonyteate tonyteate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jlpl15 jlpl15 merged commit 64e27c6 into master Feb 19, 2026
3 checks passed
@jlpl15 jlpl15 deleted the JL/MBL-2994 branch February 19, 2026 23:44
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.21%. Comparing base (fc89dfa) to head (592af5c).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2475   +/-   ##
=========================================
  Coverage     64.21%   64.21%           
  Complexity     2414     2414           
=========================================
  Files           384      384           
  Lines         29209    29209           
  Branches       4228     4228           
=========================================
  Hits          18756    18756           
  Misses         8189     8189           
  Partials       2264     2264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants