Conversation
…nt as Secret). Add Featured reward previews on KSRewardsCard.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2475 +/- ##
=========================================
Coverage 64.21% 64.21%
Complexity 2414 2414
=========================================
Files 384 384
Lines 29209 29209
Branches 4228 4228
=========================================
Hits 18756 18756
Misses 8189 8189
Partials 2264 2264 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📲 What
Wire Featured reward badge on reward cards (carousel and add-ons) in the same placement as Secret. Add Featured reward previews on KSRewardCard. Fix right-edge purple line on reward cards.
🤔 Why
Featured rewards need to be visually shown, like Secret rewards. The badge must appear wherever rewards are shown (carousel, manage pledge add-ons) so users can recognize featured rewards. The purple line on the right of cards was a layout/theme side effect and needed to be removed.
🛠 How
isFeaturedand renderKSFeaturedRewardBadgein the same three cases as Secret (above card when no image, over image bottom-start, and with “Your selection” when no image). Set Cardcolorsandborder = null, andclip(cardShape)on content to remove the right-side purple line.isFeatured = reward.isFeatured() == trueintoKSRewardCardfor reward items.Rowfor Secret + Featured when both apply, withModifier.wrapContentSize()so the badge doesn’t stretch.👀 See
Screen_recording_20260219_145145.webm
📋 QA
Test project: https://staging.kickstarter.com/projects/1613788818/tween-cats-chocolate
Secret reward link in case you want to test it full: https://staging.kickstarter.com/projects/1613788818/tween-cats-chocolate?secret_reward_token=15a36813
reward.isSecretReward() == true.KSRewardCard.ktand run the four new “Featured” previews; confirm they match the Secret preview layouts with the Featured badge.Story 📖
MBL-2994(Trello link)