Skip to content

fix: compiler warning, CLI help, CODE_OF_CONDUCT#43

Merged
kienbui1995 merged 1 commit intomainfrom
fix/polish
Apr 12, 2026
Merged

fix: compiler warning, CLI help, CODE_OF_CONDUCT#43
kienbui1995 merged 1 commit intomainfrom
fix/polish

Conversation

@kienbui1995
Copy link
Copy Markdown
Owner

@kienbui1995 kienbui1995 commented Apr 12, 2026

Polish:

  • Fix last compiler warning (FallbackProvider.fallback dead_code)
  • CLI --help now shows descriptions for all args
  • CODE_OF_CONDUCT.md added

0 warnings, 192 tests.

Summary by CodeRabbit

  • Documentation

    • Added Code of Conduct document that establishes community standards, defines contributor expectations, describes unacceptable behaviors, and outlines incident reporting and resolution procedures for the community.
  • New Features

    • Extended the CLI with new configuration flags for LLM providers, model settings, token limits, and session management, giving users greater control over execution parameters and behavior.

- Fix FallbackProvider.fallback dead_code warning
- Add help descriptions to all CLI args
- Add CODE_OF_CONDUCT.md (Contributor Covenant 2.1)

0 warnings, 192 tests.
@kienbui1995 kienbui1995 merged commit 045f7b1 into main Apr 12, 2026
3 of 4 checks passed
@kienbui1995 kienbui1995 deleted the fix/polish branch April 12, 2026 16:45
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 12, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ffa55c3f-f021-4129-895c-9bd6ee307b37

📥 Commits

Reviewing files that changed from the base of the PR and between 5b6fbd0 and 9563060.

📒 Files selected for processing (3)
  • CODE_OF_CONDUCT.md
  • mc/crates/mc-cli/src/main.rs
  • mc/crates/mc-cli/src/provider.rs

📝 Walkthrough

Walkthrough

This PR adds a CODE_OF_CONDUCT.md file establishing contributor guidelines, extends the CLI struct with new LLM provider configuration and execution control flags, and updates a fallback provider comment with a TODO note.

Changes

Cohort / File(s) Summary
Project Governance
CODE_OF_CONDUCT.md
Added contributor code of conduct document based on Contributor Covenant v2.1, defining expected behavior, reporting procedures, and enforcement guidelines.
CLI & Provider Configuration
mc/crates/mc-cli/src/main.rs, mc/crates/mc-cli/src/provider.rs
Extended Cli struct with new command-line flags for LLM/provider configuration (model, max_tokens, provider, base_url, api_key) and execution controls (verbose, resume, session_id, pipe, output). Updated fallback provider stream implementation comment to clarify TODO for stream-level fallback handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A code of conduct hops into place,
While CLI flags add features with grace,
The fallback waits for its turn to shine,
With TODOs marked and futures aligned!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/polish

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant