Skip to content

chore(deps): bump actions/upload-pages-artifact v3 → v5 (supersedes #76)#78

Merged
kienbui1995 merged 2 commits intomainfrom
chore/bump-upload-pages-artifact-v5
Apr 23, 2026
Merged

chore(deps): bump actions/upload-pages-artifact v3 → v5 (supersedes #76)#78
kienbui1995 merged 2 commits intomainfrom
chore/bump-upload-pages-artifact-v5

Conversation

@kienbui1995
Copy link
Copy Markdown
Owner

@kienbui1995 kienbui1995 commented Apr 21, 2026

What

Bumps actions/upload-pages-artifact from v3 to v5 in .github/workflows/pages.yml.

Why

Supersedes #76. That PR was opened by Dependabot and its SonarCloud Scan check fails because Dependabot-triggered workflows don't receive SONAR_TOKEN — same GitHub-level secret scoping issue as #75. Re-submitting from a regular branch so the scan can authenticate.

How

One-line change: @v3@v5.

The v4 release excludes hidden files (dotfiles) from the artifact by default. This workflow uploads docs/site/, which contains only index.html — no dotfiles — so the breaking change does not affect this pipeline.

Test plan

https://claude.ai/code/session_01R2n6wKqFkYPvHkwaip8EnJ

Summary by CodeRabbit

  • Chores
    • Updated the GitHub Pages deployment workflow to use a newer release of the upload artifact action (bumped from v3 to v5), keeping the artifact upload settings unchanged. This refreshes deployment tooling to align with the latest supported action version and reduces maintenance risk.

@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 268b76ba-d076-46dc-b9ab-30139874cd13

📥 Commits

Reviewing files that changed from the base of the PR and between beb3623 and 59dad9d.

⛔ Files ignored due to path filters (1)
  • mc/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .github/workflows/pages.yml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/pages.yml

📝 Walkthrough

Walkthrough

Updated the GitHub Pages workflow: bumped actions/upload-pages-artifact from v3 to v5. Artifact upload configuration (with.path: _site) is unchanged. This is a minor CI action version upgrade.

Changes

Cohort / File(s) Summary
GitHub Actions: Pages workflow
​.github/workflows/pages.yml
Bumped actions/upload-pages-artifact from v3 to v5; no other workflow inputs or the with.path: _site setting changed. New upstream releases include an updated upload-artifact dependency and an include-hidden-files input (not used here).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

dependencies, github_actions

Poem

🐰 A tiny hop from three to five,
I nudged the workflow so Pages thrive.
Artifacts still go to _site with cheer,
A quiet update — biscuits and beer. 🍪🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: bumping actions/upload-pages-artifact from v3 to v5, and includes context about superseding PR #76.
Description check ✅ Passed The description covers What, Why, and How sections clearly. However, the Test plan section uses checkboxes rather than confirming completion, and references an external URL that seems out of scope for a PR description.
Linked Issues check ✅ Passed The PR fulfills all coding requirements from issue #76: upgrades actions/upload-pages-artifact to v5, accounts for v4's breaking change (dotfile exclusion), and verifies workflow compatibility.
Out of Scope Changes check ✅ Passed The PR contains only the single-line change required to bump the action version; no extraneous modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-upload-pages-artifact-v5

Comment @coderabbitai help to get the list of available commands and usage tips.

claude added 2 commits April 23, 2026 03:02
Supersedes #76 (same Dependabot SONAR_TOKEN issue as #71/#75).

The v4 release excludes hidden files (dotfiles) by default. The
workflow uploads docs/site/, which contains only index.html — no
dotfiles — so the breaking change does not affect this pipeline.

https://claude.ai/code/session_01R2n6wKqFkYPvHkwaip8EnJ
Fresh transitive advisory: panic during CRL parsing. Blocks
License & Supply Chain and Dependency Audit on main, not specific
to this PR. Folding the fix here to unblock CI.

https://claude.ai/code/session_01R2n6wKqFkYPvHkwaip8EnJ
@kienbui1995 kienbui1995 force-pushed the chore/bump-upload-pages-artifact-v5 branch from b0e48b5 to 59dad9d Compare April 23, 2026 03:03
@sonarqubecloud
Copy link
Copy Markdown

@kienbui1995 kienbui1995 merged commit 0880254 into main Apr 23, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants