Skip to content

Enabled no label without control rule#2689

Merged
Lionqueen94 merged 5 commits intomainfrom
enable_no_label_without_control_rule
Dec 31, 2025
Merged

Enabled no label without control rule#2689
Lionqueen94 merged 5 commits intomainfrom
enable_no_label_without_control_rule

Conversation

@Lionqueen94
Copy link
Contributor

No description provided.

@Lionqueen94 Lionqueen94 self-assigned this Dec 30, 2025
@Lionqueen94 Lionqueen94 requested a review from a team as a code owner December 30, 2025 16:31
@Lionqueen94 Lionqueen94 added frontend Issues or pull requests that relate to the frontend tech debt Tech debt, potential refactorings labels Dec 30, 2025
@Lionqueen94 Lionqueen94 mentioned this pull request Dec 30, 2025
22 tasks
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2025-12-30.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 2 refactoring candidates were introduced or got worse.

Risk System property Location
🟠 Unit Size
(Worsened)
frontend/src/components/ui/InputField/InputField.tsx
InputField.tsx.InputField(InputFieldProps)
🟡 Unit Complexity
(Worsened)
frontend/src/components/ui/InputField/InputField.tsx
InputField.tsx.InputField(InputFieldProps)

📚 Remaining technical debt

16 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2025-12-30 Before changes New/changed code
Volume 3.4 N/A N/A
Duplication 3.7 4.4 4.4
Unit Size 2.2 2.6 2.6
Unit Complexity 3.2 2.2 2.2
Unit Interfacing 2.9 5.5 5.5
Module Coupling 3.3 5.5 5.5
Component Independence 2.1 N/A N/A
Component Entanglement 2.3 N/A N/A
Maintainability 2.9 3.8 3.8

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (4d7a5db) to head (1e951b3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2689      +/-   ##
==========================================
+ Coverage   91.85%   91.87%   +0.01%     
==========================================
  Files         375      375              
  Lines       18950    18951       +1     
  Branches     1965     1965              
==========================================
+ Hits        17407    17411       +4     
+ Misses       1449     1446       -3     
  Partials       94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

PDF Diff Summary

Comparing against base branch: main

File Status
model-n-10-2.pdf ✅ No changes
model-na-14-2-bijlage1.pdf ✅ No changes
model-na-14-2.pdf ✅ No changes
model-na-31-2-bijlage1.pdf ✅ No changes
model-na-31-2-inlegvel.pdf ✅ No changes
model-na-31-2.pdf ✅ No changes
model-p-2a.pdf ✅ No changes

@Lionqueen94 Lionqueen94 added this pull request to the merge queue Dec 31, 2025
Merged via the queue into main with commit d9029b1 Dec 31, 2025
19 checks passed
@Lionqueen94 Lionqueen94 deleted the enable_no_label_without_control_rule branch December 31, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Issues or pull requests that relate to the frontend tech debt Tech debt, potential refactorings

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants