Update election status page for CSB by lama-d3v · Pull Request #2945 · kiesraad/abacus

lama-d3v · 2026-02-25T11:08:32Z

Fixes #2933

github-actions · 2026-02-25T11:10:34Z

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-02-26.

👍 What went well?

You fixed or improved 1 refactoring candidates.

Risk	System property	Location
🟠	Unit Size (Fixed)	frontend/src/features/data_entry/components/DataEntrySection.tsx DataEntrySection.tsx.DataEntrySection()

👎 What could be better?

Unfortunately, 6 refactoring candidates were introduced or got worse.

Risk	System property	Location
🟠	Unit Size (Worsened)	frontend/src/features/election_management/components/ElectionInformationTable.tsx ElectionInformationTable.tsx.ElectionInformationTable(ElectionInformationTableProps)
🟠	Unit Size (Introduced)	frontend/src/features/data_entry/components/DataEntrySection.tsx DataEntrySection.tsx.DataEntrySection(DataEntryProps)
🟡	Unit Size (Worsened)	frontend/src/components/navbar/NavBarLinks.tsx NavBarLinks.tsx.ElectionManagementLinks(NavBarLinksProps)
🟡	Unit Complexity (Worsened)	frontend/src/features/election_management/components/ElectionInformationTable.tsx ElectionInformationTable.tsx.ElectionInformationTable(ElectionInformationTableProps)
🟡	Unit Interfacing (Introduced)	frontend/src/components/committee_session/CommitteeSessionStatus.tsx CommitteeSessionStatus.tsx.CommitteeSessionStatusLabel(ElectionRole,CommitteeSessionStatus,any)
🟡	Unit Interfacing (Introduced)	frontend/src/utils/committeeSession.ts committeeSession.ts.committeeSessionLabel(ElectionRole,number,any)

📚 Remaining technical debt

14 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property	System on 2026-02-26	Before changes	New/changed code
Volume	3.4	N/A	N/A
Duplication	3.7	5.5	5.5
Unit Size	2.2	2.1	2.1
Unit Complexity	3.3	1.7	1.7
Unit Interfacing	2.9	5.5	5.1
Module Coupling	3.2	5.5	5.5
Component Independence	5.5	N/A	N/A
Component Entanglement	N/A	N/A	N/A
Maintainability	3.5	3.8	3.8

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.

✅ Yes, these findings are useful
🔸 The findings are false positives
🔹 These findings are not important to me

View this system in Sigrid

jschuurk-kr · 2026-02-25T12:00:04Z

frontend/src/features/election_management/components/update/CommitteeSessionDetailsPage.tsx

  const [errorAlert, setErrorAlert] = useState<string | null>(null);
  const redirectToReportPage = location.hash === "#redirect-to-report";
-  const sessionLabel = committeeSessionLabel(currentCommitteeSession.number, true).toLowerCase();
+  const sessionLabel = committeeSessionLabel(election.role, currentCommitteeSession.number, true).toLowerCase();


This results in a lower-case "CSB": "Details van zitting csb".

codecov · 2026-02-25T16:27:18Z

Codecov Report

❌ Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.88%. Comparing base (59630ab) to head (bb6a3ed).

Files with missing lines	Patch %	Lines
...lection_management/components/ElectionHomePage.tsx	44.44%	5 Missing ⚠️
...c/features/data_entry/components/DataEntryPage.tsx	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2945      +/-   ##
==========================================
- Coverage   91.89%   91.88%   -0.01%     
==========================================
  Files         393      393              
  Lines       19040    19050      +10     
  Branches     2094     2102       +8     
==========================================
+ Hits        17497    17505       +8     
- Misses       1440     1442       +2     
  Partials      103      103

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2026-02-26T10:15:24Z

PDF Diff Summary

Comparing against base branch: main

File	Status
model-n-10-2.pdf	✅ No changes
model-na-14-2-bijlage1.pdf	✅ No changes
model-na-14-2.pdf	✅ No changes
model-na-31-2-bijlage1.pdf	✅ No changes
model-na-31-2-inlegvel.pdf	✅ No changes
model-na-31-2.pdf	✅ No changes
model-p-2a.pdf	✅ No changes

praseodym · 2026-02-26T10:28:43Z

frontend/src/components/committee_session/CommitteeSessionStatus.test.tsx

-    render(<CommitteeSessionStatusWithIcon status={state} userRole={role} />);
-    expect(screen.getByText(label)).toBeVisible();
-    expect(screen.getByRole("img", { hidden: true })).toHaveAttribute("data-icon", icon);
+    electionRoleValues.forEach((electionRole) => {


This re-renders within the same DOM, i.e. the additional render is appended to the document body without clearing the previous render.

Use parameterised tests with test.each/test.for instead.

praseodym · 2026-02-26T10:31:10Z

frontend/src/features/election_management/components/ElectionInformationTable.tsx

+        {election.role === "GSB" && (
+          <Table.Row key={election.id} to="polling-stations">
+            <Table.HeaderCell scope="row" className="normal">
+              {t("polling_station.title.plural")}
+            </Table.HeaderCell>
+            <Table.Cell className="underlined">
+              {numberOfPollingStations}{" "}
+              {t(`polling_station.title.${numberOfPollingStations === 1 ? "singular" : "plural"}`).toLowerCase()}
+            </Table.Cell>
+          </Table.Row>
+        )}
+        {election.role === "GSB" && (
+          <Table.Row>
+            <Table.HeaderCell scope="row" className="normal">
+              {t("counting_method_type")}
+            </Table.HeaderCell>
+            <Table.Cell>{t(election.counting_method)}</Table.Cell>
+          </Table.Row>
+        )}


These can be merged into a single {election.role === "GSB" && (...)} block

lama-d3v self-assigned this Feb 25, 2026

lama-d3v deployed to test February 25, 2026 11:10 — with GitHub Actions View deployment

lama-d3v deployed to test February 25, 2026 11:37 — with GitHub Actions View deployment

lama-d3v marked this pull request as ready for review February 25, 2026 11:50

lama-d3v requested a review from a team as a code owner February 25, 2026 11:50

jschuurk-kr reviewed Feb 25, 2026

View reviewed changes

lama-d3v force-pushed the 2933-update-election-status-page-for-csb branch from e7a0217 to 9f24a38 Compare February 25, 2026 16:20

lama-d3v deployed to test February 25, 2026 16:22 — with GitHub Actions View deployment

lama-d3v added 3 commits February 26, 2026 11:11

Updated election information for CSB/GSB (#2933)

50eb41a

Updated election status page for CSB (#2933)

afa59b2

Fixed tests

bb6a3ed

Lionqueen94 force-pushed the 2933-update-election-status-page-for-csb branch from 9f24a38 to bb6a3ed Compare February 26, 2026 10:11

Lionqueen94 deployed to test February 26, 2026 10:14 — with GitHub Actions View deployment

praseodym requested changes Feb 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update election status page for CSB#2945

Update election status page for CSB#2945
lama-d3v wants to merge 3 commits intomainfrom
2933-update-election-status-page-for-csb

lama-d3v commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026 •

edited

Loading

👍 What went well?

👎 What could be better?

📚 Remaining technical debt

⭐️ Sigrid ratings

💬 Did you find this feedback helpful?

Uh oh!

jschuurk-kr Feb 25, 2026

Uh oh!

codecov bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

praseodym Feb 26, 2026

Uh oh!

praseodym Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lama-d3v commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sigrid maintainability feedback

👍 What went well?

👎 What could be better?

📚 Remaining technical debt

⭐️ Sigrid ratings

💬 Did you find this feedback helpful?

Uh oh!

jschuurk-kr Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 26, 2026

PDF Diff Summary

Uh oh!

praseodym Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

praseodym Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Feb 25, 2026 •

edited

Loading

codecov bot commented Feb 25, 2026 •

edited

Loading