Skip to content

Refactor &! operator: use GetScriptBlock() directly and replace Regex with static HashSet#165

Draft
Copilot wants to merge 22 commits intothreadJobOperatorfrom
copilot/sub-pr-162-another-one
Draft

Refactor &! operator: use GetScriptBlock() directly and replace Regex with static HashSet#165
Copilot wants to merge 22 commits intothreadJobOperatorfrom
copilot/sub-pr-162-another-one

Conversation

Copy link

Copilot AI commented Mar 12, 2026

Addresses four code review items on InvokePipelineInBackground in MiscOps.cs.

Changes

  • Scriptblock branch rewrite (r2917467669 + r2917738697/729): Replaced the text-manipulation approach (brace-stripping, offset arithmetic, variable injection loop, ScriptBlock.Create(...)) with a single scriptBlockExpr.ScriptBlock.GetScriptBlock() call. The old approach risked returning a ScriptBlock object rather than executing the body. Users of { ... } &! should use explicit $using: scoping as with standard PowerShell job semantics. This also eliminates the duplicated variable-rewrite logic that existed in both branches.

  • Magic variable detection (r2917738673): Replaced per-call Regex.Match(...) with a private static readonly HashSet<string> s_backgroundJobMagicVariables and a StartsWith("global:", OrdinalIgnoreCase) prefix strip. Reduces per-invocation allocations.

// Before: allocates a Regex on every variable in every backgrounded pipeline
if (!Regex.Match(variableName, "^(global:){0,1}(PID|PSVersionTable|...)$", RegexOptions.IgnoreCase).Success)

// After: O(1) lookup against a pre-built, case-insensitive HashSet
var cleanVariableName = variableName.StartsWith("global:", StringComparison.OrdinalIgnoreCase)
    ? variableName.Substring(7) : variableName;
if (!s_backgroundJobMagicVariables.Contains(cleanVariableName))

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 21 commits March 11, 2026 09:52
- Added new TokenKind.AmpersandExclaim for &! operator
- Updated tokenizer to recognize &! operator
- Added BackgroundThreadJob property to PipelineAst
- Updated parser to handle &! operator for ThreadJobs
- Modified MiscOps to use Start-ThreadJob when BackgroundThreadJob is true
- Updated all token enum values to accommodate new token

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
…use compound assignment

- Moved BackgroundThreadJob property from PipelineAst to ChainableAst base class
  to make it accessible to both PipelineAst and PipelineChainAst
- Updated PipelineChainAst.Copy() to preserve BackgroundThreadJob property
- Fixed IDE0074 warning by using ??= compound assignment operator
- Fixes CS1061 error where PipelineBaseAst didn't have BackgroundThreadJob property

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Moved BackgroundThreadJob from ChainableAst to PipelineBaseAst
- This ensures the property is accessible when the parameter type is PipelineBaseAst
- Fixes CS1061 compilation error where PipelineBaseAst didn't have BackgroundThreadJob

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
…ling

- Reorganized tests into Context blocks (Runtime, Syntax, Parser, Tokenizer)
- Added tests to validate ThreadJob vs fallback behavior with -Skip conditions
- Fixed variable capture test to assert actual captured values
- Enabled and improved the && operator combination test
- Simplified exception handling in MiscOps.cs (removed unnecessary try-catch)
- GetCmdlet returns null when not found, doesn't throw in common case

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Moved TokenKind.AmpersandExclaim from position 29 to position 171 (end of enum)
- Restored all token enum values (Pipe through Clean) to their original positions
- Updated token flags and text arrays to place AmpersandExclaim at the end
- Updated PSToken.cs mapping array accordingly
- Added missing Clean entry to PSToken.cs
- This avoids breaking compiled consumers that rely on stable enum values

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Added backgroundThreadJob boolean variable to track ThreadJob intent
- Changed AmpersandExclaim case to set backgroundThreadJob variable instead of property
- Set BackgroundThreadJob property in default case alongside Background property
- Fixes issue where "1+1 &!" caused parser error because property was set on wrong pipeline

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Added case for TokenKind.AmpersandExclaim in PipelineRule switch
- Sets both background and backgroundThreadJob flags when &! is encountered
- Fixes "Unexpected token '&!'" error when using {1+1} &! syntax
- Follows same pattern as TokenKind.Ampersand case with allowBackground check

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Added backgroundThreadJob variable declaration in PipelineRule method
- Set BackgroundThreadJob property on PipelineAst when backgroundThreadJob flag is true
- Fixes CS0103 compilation error: "The name 'backgroundThreadJob' does not exist"

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Changed from GetCmdlet to GetCommand with CommandTypes.Cmdlet | CommandTypes.Function
- GetCommand will auto-import the ThreadJob module if it's available
- Properly handles CmdletInfo vs FunctionInfo by checking type and creating appropriate command info
- Fixes issue where {1+1} &! was creating BackgroundJob instead of ThreadJob
- Now correctly creates ThreadJob when ThreadJob module is available

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Use pattern matching to check if threadJobCommand is CmdletInfo
- Handle FunctionInfo case by falling back to Start-Job (functions can't be invoked in this context)
- Fixes CS1061 error: CommandInfo doesn't have ImplementingType property
- Only CmdletInfo has ImplementingType, not base CommandInfo class

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Added usingThreadJob boolean flag to track if Start-ThreadJob is actually being used
- Only add WorkingDirectory parameter for Start-Job, not Start-ThreadJob
- Start-ThreadJob doesn't support the WorkingDirectory parameter
- Fixes error: "A parameter cannot be found that matches parameter name 'WorkingDirectory'"

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Detect when pipeline is already a ScriptBlockExpressionAst (e.g., {1+1} &!)
- Extract the inner script block content directly instead of wrapping it again
- Previously {1+1} &! created ScriptBlock.Create("{1+1}") which returned literal string
- Now correctly extracts "1+1" and creates ScriptBlock.Create("1+1") which evaluates the expression
- Fixes issue where {1+1} &! returned "1+1" instead of 2

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
…essing PipelineElements

- PipelineElements property is on PipelineAst, not PipelineBaseAst
- Added type check and cast: pipelineAst is PipelineAst pipeline
- Fixes CS1061 error: 'PipelineBaseAst' does not contain a definition for 'PipelineElements'

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
- Set BackgroundThreadJob property on PipelineChainAst after creation
- Previously only passing background flag to constructor, not setting BackgroundThreadJob
- Fixes issue where "1+1 && 2+2 &!" showed as BackgroundJob instead of ThreadJob
- Now properly creates ThreadJob for pipeline chains ending with &!

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
… add Wait-Job timeouts, fix DEBUG assertions

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
…dlet resolution per PR review

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
…variables in MiscOps.cs

Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
Copilot AI changed the title [WIP] Add ThreadJobOperator Refactor &! operator: use GetScriptBlock() directly and replace Regex with static HashSet Mar 12, 2026
@kilasuit kilasuit force-pushed the threadJobOperator branch from 7414207 to 69cefb0 Compare March 12, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants