refactor: deepen modules across rust core + react widget#3
Closed
archae0pteryx wants to merge 4 commits intomainfrom
Closed
refactor: deepen modules across rust core + react widget#3archae0pteryx wants to merge 4 commits intomainfrom
archae0pteryx wants to merge 4 commits intomainfrom
Conversation
3 tasks
archae0pteryx
added a commit
that referenced
this pull request
May 4, 2026
- Log DisplayConfigState lock failure instead of silently ignoring (#3) - set_debug_overlay: only emit event when lock succeeds, not on failure (#4) - SettingsWindow: wrap onToggleDevtools in arrow to explicitly drop the boolean arg from ToggleRow onChange (#5) - Update 032 issue spec to match implemented tray/display behavior (#1)
archae0pteryx
added a commit
that referenced
this pull request
May 4, 2026
* [032] Preferences window: settings UI, tray simplification, debug overlay control - Add on-demand Preferences window (Cmd-, / tray → Settings…) - Sections: General (caps), Widget, Displays, Alerts, Debug - Auto-sizes to content via ResizeObserver + Tauri setSize - Reopens cleanly after close: destroys stale label, creates fresh window - Simplify tray: replace Settings submenu with single Settings… item - Add Tauri commands: get/update settings, get monitors, get/set debug overlay, toggle/query devtools - Debug overlay off by default; toggled via Settings > Debug > Debug Overlay using backend app.emit for reliable cross-window event delivery - DebugOverlayState managed in app; devtools toggle uses is_devtools_open * fix: address CR comments on 032 preferences window - Log DisplayConfigState lock failure instead of silently ignoring (#3) - set_debug_overlay: only emit event when lock succeeds, not on failure (#4) - SettingsWindow: wrap onToggleDevtools in arrow to explicitly drop the boolean arg from ToggleRow onChange (#5) - Update 032 issue spec to match implemented tray/display behavior (#1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task checkis green at every step.CapNotifiertrait +CapEvaluator(commands crate) replace inline cap notification in the Tauri shell.ProposalLifecycleowns proposal accept/reject end-to-end, replacing theProposalDispatcher+ per-kind appliers.useAppStatecomposes the React widget's three async readers under one readiness contract.MonitorStateremoved; oneinstall_change_handlershelper replaces the mix of inline-closure and per-watcher helper; proposal-reader errors now surface to the UI instead of being silently swallowed.Test plan
task check(lint + typecheck + Rust unit tests + web unit tests) green on the tip of the branchCapEvaluatortests, 6ProposalLifecycletests, 4useAppStateteststask devand exercise: create focus, run/checkpoint, accept/reject proposal, hit a cap