Kaui 5.06#606
Merged
tungleduyxyz merged 4 commits intomasterfrom May 6, 2026
Merged
Conversation
Contributor
tungleduyxyz
commented
May 5, 2026
- https://github.com/killbill/technical-support/issues/158: Minor update, Save search now triggers the search
- Add ability to delete overdue configuration via Kaui #595: new button to delete overdue config
- Invoice page displays invoices for a different account #605: Fix bug invoices page
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Kaui 5.06 with three user-facing changes: fixing invoice list state leakage across pages, adding overdue-config deletion from the tenant admin UI, and making saved searches immediately apply after saving. These changes touch both tenant administration flows and the invoice/payment search stack.
Changes:
- Add overdue configuration deletion support in the admin tenant UI, plus controller handling, route wiring, locale strings, and functional tests.
- Fix invoice/payment/account-id handling so advanced-search params don’t get misread as an account context.
- Update invoice DataTables state persistence and make “Save search” immediately trigger the search.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
test/functional/kaui/admin_tenants_controller_test.rb |
Adds controller coverage for uploading/modifying then deleting overdue configs. |
lib/kaui/error_handler.rb |
Hardens account-id extraction during error redirects. |
config/routes.rb |
Adds DELETE route for overdue config removal. |
config/locales/en.yml |
Adds success/confirmation strings for overdue deletion. |
app/views/kaui/invoices/index.html.erb |
Adjusts DataTables state key handling for invoice pages. |
app/views/kaui/admin_tenants/new_overdue_config.html.erb |
Adds the Delete button and confirmation prompt to the overdue config page. |
app/controllers/kaui/payments_controller.rb |
Uses sanitized scalar account-id handling and skips account lookup for advanced-search queries. |
app/controllers/kaui/invoices_controller.rb |
Same account-id / advanced-search handling changes for invoices. |
app/controllers/kaui/engine_controller.rb |
Uses sanitized scalar account-id when populating account context. |
app/controllers/kaui/engine_controller_util.rb |
Introduces helpers for normalizing search keys, detecting advanced queries, and safely reading scalar account ids. |
app/controllers/kaui/admin_tenants_controller.rb |
Tracks overdue-config existence and adds delete action implementation. |
app/assets/javascripts/kaui/multi_functions_bar_utils.js |
Makes saved searches immediately apply after being saved. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.