Skip to content

Added rubocop extensions#78

Merged
tungleduyxyz merged 1 commit intokillbill:masterfrom
tungleduyxyz:kaui_4.8
Apr 8, 2026
Merged

Added rubocop extensions#78
tungleduyxyz merged 1 commit intokillbill:masterfrom
tungleduyxyz:kaui_4.8

Conversation

@tungleduyxyz
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates linting support by enabling additional RuboCop extension packs and applies small Rails code modernizations/cleanups to align with the new cops.

Changes:

  • Add RuboCop extension gems (Rails, RSpec, Performance, ThreadSafety) and enable/configure them in .rubocop.yml (incl. Ruby 3.2 target).
  • Modernize a few Rails patterns (routing DSL matchget/put, blank?/present? usage, Time.zone.today, keyword shorthand).
  • Adjust a placeholder controller test base class to ActionDispatch::IntegrationTest.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Gemfile Adds RuboCop extension gems to support new lint rule sets.
.rubocop.yml Requires/enables RuboCop extensions and configures Rails/RSpec/Performance/ThreadSafety departments and Ruby target version.
config/routes.rb Replaces match ... via: routes with explicit get/put.
app/helpers/kanaui/dashboard_helper.rb Minor conditional cleanup using present?.
app/controllers/kanaui/dashboard_controller.rb Timezone-aware date defaulting and small parameter/keyword cleanups.
app/controllers/kanaui/reports_controller.rb Method ordering change only (no functional change).
test/test_helper.rb Small change to support-file requiring loop.
test/functional/kanaui/tests_controller_test.rb Updates test superclass to integration test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tungleduyxyz tungleduyxyz merged commit cb13a38 into killbill:master Apr 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants