Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates linting support by enabling additional RuboCop extension packs and applies small Rails code modernizations/cleanups to align with the new cops.
Changes:
- Add RuboCop extension gems (Rails, RSpec, Performance, ThreadSafety) and enable/configure them in
.rubocop.yml(incl. Ruby 3.2 target). - Modernize a few Rails patterns (routing DSL
match→get/put,blank?/present?usage,Time.zone.today, keyword shorthand). - Adjust a placeholder controller test base class to
ActionDispatch::IntegrationTest.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Gemfile |
Adds RuboCop extension gems to support new lint rule sets. |
.rubocop.yml |
Requires/enables RuboCop extensions and configures Rails/RSpec/Performance/ThreadSafety departments and Ruby target version. |
config/routes.rb |
Replaces match ... via: routes with explicit get/put. |
app/helpers/kanaui/dashboard_helper.rb |
Minor conditional cleanup using present?. |
app/controllers/kanaui/dashboard_controller.rb |
Timezone-aware date defaulting and small parameter/keyword cleanups. |
app/controllers/kanaui/reports_controller.rb |
Method ordering change only (no functional change). |
test/test_helper.rb |
Small change to support-file requiring loop. |
test/functional/kanaui/tests_controller_test.rb |
Updates test superclass to integration test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pierre
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: killbill/killbill-admin-ui#345