API - Get Currently Loaded Subtitle

[bpwhelan]

Is your feature request related to a problem? Please describe.

There are certain applications that interface with asbplayer, but need to load the subtitle independently to work properly. One such example is https://github.com/mcgrizzz/Yomine

Describe the solution you'd like

A simple http endpoint to grab the currently loaded subtitle. Pretty much the same thing as "Download Subtitles as SRT" option, but via HTTP.

Describe alternatives you've considered

At the moment you can just download via the button, which is fine, an http endpoint would just be a 100% convenience thing.

Additional context

I may or may not work on this if it's even possible in the first place. Should just be an HTTP endpoint and websocket message/reply. Please let me know if this would be denied if PR'd.

[mcgrizzz]

+1

One thing to keep in mind: asbplayer can have multiple tabs active at the same time (e.g. Crunchyroll in one tab and YouTube in another, each with its own subtitles on the video element). The sidebar can only ever show one track at a time, though.

Because of that, I could see two possible scopes for this endpoint:

• Sidebar-scoped: the endpoint always returns the subtitles currently loaded in the sidebar (simple but may cause confusion if a user is going back and forth between tabs)
• Tab/video-scoped: the endpoint takes some kind of tab/video identifier so clients can ask for the subtitles for a specific active tab.

In the latter case, there'd probably need to be a convenience method to grab a list of active tabs.

Happy to help with this.

[killergerbah]

I think whatever you do it should match the load-subtitles logic for consistency. By default it targets the active tab and assumes there's only one video element on the tab. That logic may need to be improved.