add verification to NotOnOrAfter date#9
Merged
guyneedhamcanva merged 3 commits intomasterfrom Mar 16, 2026
Merged
Conversation
jontyt
approved these changes
Jan 28, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
guyneedhamcanva
force-pushed
the
guyn-saml-not-after-check
branch
from
d835a92 to
aead004
Compare
guyneedhamcanva
changed the base branch from
guyn-update-fork-from-upstream
to
master
In @xmldom/xmldom 0.8.x, getAttribute returns "" for non-existent
attributes, not null. The CoffeeScript existential check only guards
against null/undefined, so an empty string passed through causing
Date.parse("") to return NaN and falsely reject valid SAML responses
where NotOnOrAfter is optional per SAML spec.
Use hasAttribute to properly check if the attribute exists before
getting its value.
Added tests for:
- Missing NotOnOrAfter attribute (should be accepted)
- Empty NotOnOrAfter attribute (should be rejected)
- Malformed NotOnOrAfter attribute (should be rejected)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to unskip this test: https://github.com/kiln/flourish/blob/169bd480245342ffaf609401470e21708d6c98ab/server/test/app/user/saml.ts#L203
Adds an assertion that the Subject NotOnOrAfter cannot be too old.