Blueprint: Use rsvp instead of ember-cli/lib/ext/promise#147
Merged
kimroen merged 2 commits intokimroen:masterfrom Apr 2, 2018
Merged
Blueprint: Use rsvp instead of ember-cli/lib/ext/promise#147kimroen merged 2 commits intokimroen:masterfrom
kimroen merged 2 commits intokimroen:masterfrom
Conversation
kimroen
requested changes
Sep 5, 2017
Owner
kimroen
left a comment
kimroen
left a comment
There was a problem hiding this comment.
Just add this dependency, and this should be all good. Thanks a bunch!
| @@ -1,5 +1,5 @@ | |||
| var inflection = require('inflection'); | |||
| var Promise = require('ember-cli/lib/ext/promise'); | |||
| var RSVP = require('rsvp'); | |||
Owner
There was a problem hiding this comment.
I think we get rsvp through an implicit dependency (probably ember-cli), but we should add it as a dependency directly in package.json.
Contributor
Author
There was a problem hiding this comment.
Thanks, I'll try!
Contributor
Author
There was a problem hiding this comment.
(And, thanks so much for supporting this thing!)
kimroen
approved these changes
Sep 5, 2017
Owner
|
Thanks again for this! I'm focusing on getting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to avoid the Deprecation warning
Fixes #143