feat: upgrade httpx dependency version#99
Conversation
WalkthroughThe version constraint for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
requirements.txt (1)
3-11: Remove duplicatepython-dotenventry
python-dotenv>=1.0.0is listed twice (Line 3 and Line 11). Keeping a single occurrence avoids confusion and makes dependency metadata cleaner.-python-dotenv>=1.0.0 ... -python-dotenv>=1.0.0
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pyproject.tomlis excluded by!**/*.toml
📒 Files selected for processing (1)
requirements.txt(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: brettchaldecott
PR: kinde-oss/kinde-python-sdk#49
File: requirements.txt:0-0
Timestamp: 2025-02-20T10:32:33.692Z
Learning: PyJWT version 2.8.0 and above supports Python 3.8+. The version constraint should be kept at >=2.8.0 as it already provides the required Python version compatibility.
🔇 Additional comments (1)
requirements.txt (1)
35-37: Upper-bounded constraint needs confirmation against transitive dependencies
httpx>=0.25.0,<0.29.0blocks the not-yet-released 0.29 line but still allows 0.28.*, which could contain backward-incompatible API changes (httpx is pre-1.0 and makes breaking changes in minor bumps).
Please run the full test-suite with0.28.*(and ideally0.27.*) to ensure nothing breaks, or tighten the upper bound further (<0.28.0) if risk appetite is low.
- Update pyproject.toml with required changes for user details bug fix
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Explain your changes
Upgrade the httpx dependency version
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.