Conversation
Signed-off-by: Elliot Murphy <statik@users.noreply.github.com>
Signed-off-by: Elliot Murphy <statik@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| formattedJSON, err := json.MarshalIndent(data, "", " ") | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| log.Fatal().Err(err).Msg("Trouble marshalling to JSON") |
Contributor
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶marshalling is a misspelling of marshaling (misspell)
|
|
||
| func init() { | ||
| zerolog.TimeFieldFormat = time.RFC3339 | ||
| if isatty.IsTerminal(os.Stdout.Fd()) { |
Contributor
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
if statements should only be cuddled with assignments used in the if statement itself (wsl)
Member
Author
|
Before and after example of log messages on terminal
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now log messages are structured json if not on tty, on tty colored output. Log messages include source file location and more consistent error extraction. Using zero allocation logger package.