This repository was archived by the owner on May 14, 2021. It is now read-only.
Set one kin = 1000000 units ==> 5 decimal points#16
Merged
oryband merged 1 commit intokinecosystem/masterfrom Nov 13, 2018
Merged
Set one kin = 1000000 units ==> 5 decimal points#16oryband merged 1 commit intokinecosystem/masterfrom
oryband merged 1 commit intokinecosystem/masterfrom
Conversation
Author
|
The change is completely untested. I didn't even build. Please do so and run through the tests. I have no way of figuring out which unit tests may fail because of this change, and I don't know if the change will even have the desired effect. |
oryband
force-pushed
the
kin_native
branch
3 times, most recently
from
64ab485 to
67d1467
Compare
oryband
changed the title
|
FYI: will update tests where necessary in a future branch |
- instead of 7 (10000000) previously - this allows for a single account to hold 10 trillion native tokens
Author
|
My first comment was correct. You changed the spec without communicating to anyone who is actually affected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.