Skip to content
This repository was archived by the owner on May 14, 2021. It is now read-only.

Add '[horizon|core]-db-[open|idle]-max-connections' command line flags to specify number of db connections to use#4

Merged
oryband merged 1 commit intokinecosystem/masterfrom
gadi/db_connections_change
Aug 20, 2018
Merged

Add '[horizon|core]-db-[open|idle]-max-connections' command line flags to specify number of db connections to use#4
oryband merged 1 commit intokinecosystem/masterfrom
gadi/db_connections_change

Conversation

@gadisr
Copy link
Copy Markdown

@gadisr gadisr commented Aug 19, 2018

No description provided.

@gadisr gadisr requested a review from oryband August 19, 2018 09:49
@gadisr gadisr force-pushed the gadi/db_connections_change branch from f70681d to f27c6ac Compare August 19, 2018 10:06
@oryband oryband changed the title Added the '[horizon|core]-db-[open|idle]-max-connections' command line flags to specify number of db connections to use Add '[horizon|core]-db-[open|idle]-max-connections' command line flags to specify number of db connections to use Aug 19, 2018
Copy link
Copy Markdown

@oryband oryband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, please see comments

Comment thread services/horizon/main.go
StaleThreshold: uint(viper.GetInt("history-stale-threshold")),
SkipCursorUpdate: viper.GetBool("skip-cursor-update"),
HorizonDBMaxOpenConnections: viper.GetInt("horizon-db-max-open-connections"),
HorizonDBMaxIdleConnections: viper.GetInt("horizon-db-max-idle-connections"),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should called "history" instead of "horizon", like everywhere else. wdyt?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind, "horizon" makes more sense here.

@oryband oryband merged commit 4167883 into kinecosystem/master Aug 20, 2018
@oryband oryband deleted the gadi/db_connections_change branch August 20, 2018 09:42
oryband added a commit that referenced this pull request Sep 20, 2018
all these changes will be included in this branch
since they all belong to the same related long term solution for sse optimization
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants