KCI-156

[jvhellemondt]

Fixed:

• Add icon "added"
• Cannot call class as function -> reverted to how it was.
• chevron left and right
• Vuetify resource icons show up as json. Seems to be fixed

[DennisLammers]

Ik vind prima, maar wacht maar op @ricardovanlaarhoven :P

[ricardovanlaarhoven]

Sowieso denk ik dat vuetify resource standalone hoort te zijn. Als vuetify niet levert, dan moet de resource zelf iets doen. Doordat we nu SVG gebruiken, zal dat niet veel schelen in de bundle.

i don't agree with that. Vuetify is a peer dependency of the vuetify-resource so you should install that yourself. Just like vue is a peer dependency of vuetify.
The vuetify-resource uses the vuetify icon variables so you can choose your own iconfont and your own icons.

[ricardovanlaarhoven]

chevron left en right

Zitten er in, onder prev / next. Volgens mij worden die gebruikt. Maar als het vuetify resource betreft, dan is dat misschien >anders. Ik heb in vuetify resource gezocht... Maar kon het niet vinden.

Perhaps this was an issue with fontawesome free.

If you've tested it then we can close that issue.
This was about a console warning when using the application in the browser. It said those icons were missing.

[jvhellemondt]

Sowieso denk ik dat vuetify resource standalone hoort te zijn. Als vuetify niet levert, dan moet de resource zelf iets doen. Doordat we nu SVG gebruiken, zal dat niet veel schelen in de bundle.

i don't agree with that. Vuetify is a peer dependency of the vuetify-resource so you should install that yourself. Just like vue is a peer dependency of vuetify.
The vuetify-resource uses the vuetify icon variables so you can choose your own iconfont and your own icons.

Vuetify would still be a peer-dependency. And you should be able to overwrite the icons. However, I'd rather have a working vuetify-resource on icons, by default.

[ricardovanlaarhoven]

there is much more then just vuetify, So should this line be here?

just like above.
my referer to the installation is not really notable, perhaps just change that

[jvhellemondt]

It is the full instruction to locally test the cli:

[ricardovanlaarhoven]

No it isn't. Just like i said before there is much more then vuetify.

vue router
vuex
dart sass
..
..

For development you need to follow the instructions "just like above"
You could add those instructions just like you've added vuetify again at this place. But then you should remove the "just like above"
When you do that we'd have to maintain that at two places so i'm opting to revert your change and just make the line "just like above" more notable.

Something like this:

### Development
- To test/develop the kingscode scaffold you can locally invoke this plugin.
create a test project (`vue create scaffold-tester`) just like in the Installation part, you can follow those instructions and continue here.

- install the cli-plugin locally

`npm install path\to\local\vue-cli-plugin-kingscode-scaffold`

- invoke the plugin

`vue invoke kingscode-scaffold`

[jvhellemondt]

I'm not sure why you keep pushing. The only fact is, my icon changes made Vuetify the only one mandatory for this cli (according to the instructions). Vue router, vuex and even dart sass (the dart sass thing is not required, if you don't select css pre-processors), are optional (according to the instructions. I did no changes in that). Thus without 'adding' vuetify, the development instruction is incomplete.

I do not mind changing the 'just like above' part. However, I think it's still valid.

[ricardovanlaarhoven]

Let's call about this.
BTW PR was already approved so i'm not pushing but in my opinion this adds more confusion instead of removing it.