Prevent NativeEventObserver crash during monitor events#83
Merged
robertherber merged 1 commit intokingstinct:mainfrom Feb 2, 2026
Merged
Prevent NativeEventObserver crash during monitor events#83robertherber merged 1 commit intokingstinct:mainfrom
robertherber merged 1 commit intokingstinct:mainfrom
Conversation
commit: |
Member
|
Thanks for your contribution @joe2708! Have gotten this as well at times |
Contributor
Author
Glad this resonates. After applying the patch, this reduced crashes during save/sync monitor churn by hardening the observer callback lifecycle. It significantly lowers this intermittent EXC_BAD_ACCESS path, but it can’t guarantee 100% crash-free behaviour for every edge case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit an intermittent iOS crash during DeviceActivity monitor event flows (save/sync/start-stop), with stack traces pointing to NativeEventObserver.registerListener and crash signatures like EXC_BAD_ACCESS / KERN_PROTECTION_FAILURE.
This PR hardens the native observer callback lifecycle:
No JS API or feature behavior changes in this PR; this is an iOS native stability fix only to prevent unwanted crashes during saving schedules.