Skip to content

Conversation

@mario-fuentes
Copy link
Collaborator

...reateTestCaseStep' and 'deleteTestCaseStep', these methods will be availables on 1.9.4 release.

… 'createTestCaseStep' and 'deleteTestCaseStep', these methods will be availables on 1.9.4 release.
@kinow
Copy link
Owner

kinow commented Dec 2, 2011

Hiya Mario, I will review this pull request throughout the weekend. Thank you very much! Hope this was the first one of man ;)

Bests, B

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the beginning I didn't understand why you used the internal:boolean parameter. But after reading your javadoc comment I see your point. The TestLink API has some parts of the code where the same parameter is used for different things, as well as parts where the parameter name is different but with the same use.

@kinow
Copy link
Owner

kinow commented Dec 8, 2011

Mario, your code is very neat, well formatted and the tests are in place :-) thanks for the the hard work. What did you use to capture the XML? Wireshark? I'm merging your changes and including you as contributor to the git repository.

kinow added a commit that referenced this pull request Dec 8, 2011
Merging changes by Mario Fuentes. Welcome aboard mate, you've been included as contributor in the GitHub project.
@kinow kinow merged commit 3bbe1df into kinow:master Dec 8, 2011
@mario-fuentes
Copy link
Collaborator Author

To capture the XML is uses a small Python script with i'm testing the xmlrpc services.

@kinow
Copy link
Owner

kinow commented Dec 8, 2011

Hmmm, you could add this script to your github repositories ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants