Merged
Conversation
triszt4n
requested changes
Jul 31, 2021
Member
triszt4n
left a comment
triszt4n
left a comment
There was a problem hiding this comment.
I liked it, left a little comment down below 💎
Some thought: This PR also raises the thought of maybe building some sort of filtering component onto the groups index page 😄
| case 201: | ||
| sendMessage(`Csoport sikeresen ${edited ? 'frissítve' : 'létrehozva'}`, 'success') | ||
| location.href = '/groups' | ||
| location.href = `/groups/${data.id}` |
Comment on lines
+12
to
+17
| if past === 'true' | ||
| +inactiveButton('/groups', 'Következők') | ||
| +activeButton('/groups?past=true', 'Korábbiak') | ||
| else | ||
| +activeButton('/groups', 'Következők') | ||
| +inactiveButton('/groups?past=true', 'Korábbiak') |
Member
There was a problem hiding this comment.
Maybe the text Következők is not UX friendly enough. What do you think of 'Elkövetkezőek' or 'Indulás előttiek'?
Member
Author
There was a problem hiding this comment.
Facebook uses 'Közelgő események', but all the options sounds weird, especially without 'események' or 'csoportok' at the end, but otherwise it would be quite long... (especially on mobile)
Member
There was a problem hiding this comment.
Yeah true, I think this can stay as 'Következők' :)
triszt4n
approved these changes
Aug 2, 2021
OmTheTurtle
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Separate upcoming and past events on groups page #464