Optimize collision frames#6
Open
lucaswerkmeister wants to merge 1 commit into
Open
Conversation
The freeze-frame at the end of a collision consists of 45 identical frames that don’t depend on the loop variable (i). There’s no need to calculate the same frame 45 times – just calculate it once and then write it 45 times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The freeze-frame at the end of a collision consists of 45 identical frames that don’t depend on the loop variable (
i). There’s no need to calculate the same frame 45 times – just calculate it once and then write it 45 times.Note that, while the last 45 PNGs look identical to me, they’re not identical files (different checksums). I don’t know enough about the PNG format to judge why that is. Also, this seems to result in no wall-clock speedup – I ran two simulations reproducing this post, with and without this optimizations, and in both cases the freeze-frame took 60 seconds (timed manually, so plus or minus one or two seconds to account for my reaction time and stuff). I guess writing the PNGs is more expensive than generating them? 🤷
Anyway, feel free to either merge or close this :)