Skip to content

Add closedby property on HtmlDialogTag#461

Merged
arthurfiorette merged 3 commits intokitajs:masterfrom
8549:8549-fix-460
Feb 10, 2026
Merged

Add closedby property on HtmlDialogTag#461
arthurfiorette merged 3 commits intokitajs:masterfrom
8549:8549-fix-460

Conversation

@8549
Copy link

@8549 8549 commented Feb 8, 2026

Fixes #460.
Changelog:

  • Added "closedby" property and allowed values on HtmlDialogTag interface to comply with HTML spec.

Signed-off-by: 8549 <15671077+8549@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2026

🦋 Changeset detected

Latest commit: 8706927

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kitajs/html Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

arthurfiorette
arthurfiorette previously approved these changes Feb 9, 2026
@arthurfiorette
Copy link
Member

@8549 can you please add a changelog?

@8549
Copy link
Author

8549 commented Feb 9, 2026

@arthurfiorette I added it to my previous comment. If you instead need a changeset as the bot suggested, I'll try to edit it in.

@arthurfiorette
Copy link
Member

@8549 It must have a changeset entry to be released

8549 added 2 commits February 10, 2026 16:23
Signed-off-by: 8549 <15671077+8549@users.noreply.github.com>
@8549
Copy link
Author

8549 commented Feb 10, 2026

@arthurfiorette Done!

@arthurfiorette arthurfiorette merged commit ab63a14 into kitajs:master Feb 10, 2026
1 check passed
@arthurfiorette arthurfiorette mentioned this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HtmlDialogTag is missing "closedby" attribute

2 participants