This repository was archived by the owner on Jun 17, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 443
Cut off iOS 8 support #188
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kitasuke
commented
Apr 18, 2016
- NSLayoutAnchor
- Refactoring
Conflicts: Pod/Classes/MenuItemView.swift
Conflicts: Example/Podfile.lock Pod/Classes/MenuView.swift
Conflicts: Example/Podfile.lock
Conflicts: Pod/Classes/MenuItemView.swift Pod/Classes/PagingMenuController.swift
Conflicts: Pod/Classes/MenuItemView.swift Pod/Classes/PagingMenuController.swift
Conflicts: Pod/Classes/MenuItemView.swift
Conflicts: Pod/Classes/MenuItemView.swift
|
Seriously? Seems still over 15% percentage of the active devices are using iOS 8 or earlier as of May 2016 |
Owner
Author
|
This won't be merged soon. |
Conflicts: Pod/Classes/MenuItemView.swift Pod/Classes/MenuView.swift Pod/Classes/PagingMenuController.swift
Conflicts: Example/Podfile.lock
Conflicts: Example/Podfile.lock
|
iOS <8 is 3% Why deprecating iOS 8? |
Owner
Author
|
This PR will be merged once iOS 10 is released. |
|
But if I move to swift 3, then I can't support iOS 8 anymore with this library? |
Owner
Author
|
I'll create iOS8 support branch in Swift 3, so you can use this library with the branch. However, it might not be maintained since master branch will support iOS 9+ and use Swift 3. |
Conflicts: Pod/Classes/MenuItemView.swift Pod/Classes/MenuView.swift Pod/Classes/PagingMenuController.swift Pod/Classes/PagingViewController.swift
Conflicts: Example/Podfile.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.