Merged
Conversation
pleek91
reviewed
Mar 23, 2024
src/main.ts
Outdated
| throw new Error(`Handler must be given for ${String(event)} event`) | ||
| } | ||
|
|
||
| const { event, handler } = verifyEventAndHandler(globalHandlerOrEvent, maybeHandler) |
Collaborator
There was a problem hiding this comment.
I think something like this is more straight forward even if its a little less DRY. That way these methods (which are pretty simple) contain all their own business logic and don't require reading utilities to understand what they do.
const event = globalHandlerOrEvent
if(!isHandler(handler) {
throw new MissingEventHandlerError(event)
}
on(event, handler)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
primary objective: add function overload to
oncefor global eventseveral other side quests along the way that are totally optional for you to consider