Default params always optional

[stackoverfloweth]

I've tripped over this multiple times and I'm not sure why we didn't just build it this way from the beginning.

Currently, a param with a default value is still considered required when stringifying

const url = createUrl({
  path: withParams('/[foo]', { foo: withDefault(Number, 42) }),
})

url.stringify()
//  ^ TS ERROR ❌

This PR updates that logic so that a parm with a default is always considered to be optional.

const url = createUrl({
  path: withParams('/[foo]', { foo: withDefault(Number, 42) }),
})

url.stringify()
//  ^ ok ✅

also works nicely for new query param syntax

const url = createUrl({
  query: {
    foo: withDefault(String, 'abc'),
  },
})

const response = url.stringify()
//  ^ ok ✅

[netlify]

✅ Deploy Preview for kitbag-router ready!

Name	Link
🔨 Latest commit	7547d86
🔍 Latest deploy log	https://app.netlify.com/projects/kitbag-router/deploys/698f59e1135f1300087772d0
😎 Deploy Preview	https://deploy-preview-699--kitbag-router.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[pleek91]

I could have sworn this is how it worked all along. Did we lose this when we did the url refactor maybe?

[stackoverfloweth]

I could have sworn this is how it worked all along. Did we lose this when we did the url refactor maybe?

I know It was like this before the createUrl stuff, not sure if it goes back further