Add ability to get effective response URI#69
Merged
adamwathan merged 3 commits intokitetail:masterfrom Jun 10, 2019
fyrts:master
Merged
Add ability to get effective response URI#69adamwathan merged 3 commits intokitetail:masterfrom fyrts:master
adamwathan merged 3 commits intokitetail:masterfrom
fyrts:master
Conversation
peter279k
reviewed
Jun 5, 2019
| } | ||
|
|
||
| /** @test */ | ||
| function can_retrieve_effective_uri() |
There was a problem hiding this comment.
It misses public hint for this method.
Contributor
Author
There was a problem hiding this comment.
I'm all for adding the public hint, but wouldn't that make it inconsistent with the other tests, considering that they don't have any visibility hints declared either?
|
The PR has been conflicts, and it should merge |
# Conflicts: # src/Zttp.php
Contributor
|
cc @adamwathan any chance of this getting in? |
Contributor
|
Can we change |
Contributor
|
Tagged a new release, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how I would go about reducing the send method to a single expression. Any suggestions?